Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#34 - added usage document in JSDoc #68

Merged
merged 2 commits into from Feb 23, 2019
Merged

#34 - added usage document in JSDoc #68

merged 2 commits into from Feb 23, 2019

Conversation

rahgurung
Copy link
Contributor

@rahgurung rahgurung commented Feb 22, 2019 •
edited

Fixes #34

@rahgurung
Copy link
Contributor Author

@piotrwitek PTAL

@piotrwitek
Copy link
Owner

Thanks I'll review in a few hours

@piotrwitek piotrwitek mentioned this pull request Feb 22, 2019
Merged
piotrwitek
piotrwitek requested changes Feb 22, 2019
View reviewed changes
Copy link
Owner

@piotrwitek piotrwitek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gurungrahul2, great work! I posted a few readability improvements over the original documentation examples. Would be great if you can tackle it 💪

src/mapped-types.ts Outdated Show resolved Hide resolved
src/mapped-types.ts Show resolved Hide resolved
src/mapped-types.ts Show resolved Hide resolved
@rahgurung
Copy link
Contributor Author

@piotrwitek pushed a commit,PTAL

@piotrwitek
Copy link
Owner

Looking good @gurungrahul2, great work here.

@piotrwitek piotrwitek merged commit 2270530 into piotrwitek:master Feb 23, 2019
@rahgurung
Copy link
Contributor Author

I'm even more excited about the 2nd part, let's get it next.

@rahgurung rahgurung deleted the 34 branch February 23, 2019 13:02
@piotrwitek
Copy link
Owner

piotrwitek commented Feb 23, 2019 •
edited

@gurungrahul2 happy to hear that ❤️ Please remember to submit your PR for an issuehunt reward here: https://issuehunt.io/repos/76400842/issues/34

@rahgurung
Copy link
Contributor Author

@piotrwitek done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrwitek piotrwitek piotrwitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rahgurung @piotrwitek