Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

void O2Requestor::onRequestError(QNetworkReply::NetworkError error) has destructive debugging printout #90

Closed
mcyril opened this issue Jul 28, 2017 · 0 comments
Closed

void O2Requestor::onRequestError(QNetworkReply::NetworkError error) has destructive debugging printout #90

mcyril opened this issue Jul 28, 2017 · 0 comments

Comments

@mcyril
Copy link

mcyril commented Jul 28, 2017

the line

qDebug() << reply_->readAll();

flushes reply body to output which caused return of empty data in finished signal (when finish tries to perform readAll as well)
pipacs added a commit that referenced this issue Jul 30, 2017
@pipacs
Merge pull request #91 from Timac/#90-destructive-debugging-printout
d777d55 
Fix for #90: Remove destructive debug logging
@pipacs pipacs closed this as completed Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcyril @pipacs