Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for several compile warnings and errors #57

Closed
wants to merge 3 commits into from

Conversation

Vogtinator
Copy link
Contributor

Many projects build without Qt keywords enabled, so signals and slots are syntactically invalid. Also fix a compile error and warnings about a superfluous semicolon.

- Missing QUrl construction
- Different types in ?:
- For compatibility with code using QT_NO_KEYWORDS
@pipacs
Copy link
Owner

pipacs commented Jul 1, 2016

Not a bad idea, but then let's implement it properly:

  • You replaced signals, slots, but forgot about emit
  • The examples shouldn't be changed as they build with keywords enabled

@pipacs pipacs closed this Jul 1, 2016
@Vogtinator
Copy link
Contributor Author

Both issues fixed, please repoen this PR as I can't do it.

@pipacs
Copy link
Owner

pipacs commented Jul 1, 2016

Strange: I can’t reopen this either. Please submit it as a new change.

Thanks,
Akos.

On 01 Jul 2016, at 19:52, Fabian Vogt notifications@github.com wrote:

Both issues fixed, please repoen this PR as I can't do it.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants