Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the diff message for sensitive data #1133

Merged
merged 3 commits into from Nov 24, 2020

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Nov 21, 2020

What this PR does / why we need it:

  • change to simple message(****) for sensitive data

Which issue(s) this PR fixes:

Fixes #930

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

CLA

Welcome @sanposhiho!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@sanposhiho
Copy link
Member Author

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@pipecd-bot pipecd-bot added size/S and removed size/XS labels Nov 21, 2020
@nakabonne
Copy link
Member

@sanposhiho Hey, thanks for your contribution! Looks pretty neat :-D
/trigger presubmits

@nakabonne
Copy link
Member

/lgtm

@nakabonne
Copy link
Member

/trigger presubmits

@nghialv nghialv changed the title change to simple message for sensitive data Simplify the diff message for sensitive data Nov 24, 2020
@pipecd-bot
Copy link
Collaborator

TRIGGER

@nakabonne: Your requested presubmits has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.96%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/piped/diff/renderer.go WithMaskPath -- 0.00% +0.00%
pkg/app/piped/diff/renderer.go WithRedactPath 0.00% -- +-0.00%

@pipecd-bot pipecd-bot removed the lgtm label Nov 24, 2020
@nghialv
Copy link
Member

nghialv commented Nov 24, 2020

@sanposhiho Thanks for your pull request.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nakabonne
Copy link
Member

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nakabonne: Your requested presubmits has been scheduled in response to this comment.

@nakabonne
Copy link
Member

@sanposhiho I can’t wait to work with you 😄

@pipecd-bot pipecd-bot merged commit bc34a1e into pipe-cd:master Nov 24, 2020
@pipecd-bot pipecd-bot mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the diff message for sensitive data
4 participants