Use code splitting for web frontend #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage for golang is |
|
/lgtm |
|
Code coverage for javascript is |
khanhtc1202
reviewed
Jan 20, 2021
| @@ -5,7 +5,7 @@ | |||
| }, | |||
| "allowUnreachableCode": false, | |||
| "baseUrl": ".", | |||
| "module": "CommonJS", | |||
| "module": "esnext", | |||
There was a problem hiding this comment.
nits, is it safe to use esnext over a specific version of js 👀
There was a problem hiding this comment.
@khanhtc1202 Yes, it's safe because we use webpack after compiling with typescript.
If it is broken, the webpack build should fail.
There was a problem hiding this comment.
got it, thanks for your explaining 🙆♀️
|
🚀 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: