Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clearing filter for applications #1819

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Fix clearing filter for applications #1819

merged 1 commit into from
Apr 1, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Apr 1, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1786

Does this PR introduce a user-facing change?:

Fix clearing filter for applications

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Remove showCounts parameter after implements showCounts API

https://github.com/pipe-cd/pipe/blob/5fcca1a3330cede756b4b53f82a9daa2e01e77a5/pkg/app/web/src/pages/applications/index.tsx#L54-L57

This was created by todo plugin since "TODO:" was found in 5fcca1a when #1819 was merged. cc: @cakecatz.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.26%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

thanks 😀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 79154f9 into master Apr 1, 2021
@pipecd-bot pipecd-bot deleted the fix-clear-filter branch April 1, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When clear the filter, application counts are displayed
3 participants