-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update guide to migrate datastore to mysql post #1841
Conversation
@@ -106,7 +106,7 @@ Please note that the phases (Incubating, Alpha, Beta, and Stable) are applied to | |||
| GitHub & GitHub Enterprise SSO | Beta | | |||
| Google SSO | Incubating | | |||
| Data Store - Support GCP [Firestore](https://cloud.google.com/firestore) | Beta | | |||
| Data Store - Support [MongoDB](https://www.mongodb.com/) | Alpha ([deprecated](/blog/2021/04/01/migrate-control-plane-datastore-to-mysql/)) | | |||
| Data Store - Support [MongoDB](https://www.mongodb.com/) | Alpha ([deprecated](/blog/2021/04/01/migrate-control-plane-datastore-from-mongodb-to-mysql)) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the link path is still migrate-control-plane-datastore-to-mysql
because it's based on the markdown file name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used to think like you too 😂 But tested with the new link 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really? A little bit odd 🤔
I don't know but someone may be subscribing to this blog and bookmark this page. We want to avoid the link change as much as possible. but well, It's on you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right 👍 I unchanged the link to that post 🙏
/approve |
Okay, our hugo builds the link based on the post's title, huh. I feel it can be changed but good enough to be this 👍 |
Sure, will check the Hugo link build logic later for that kind of issue 🙏 |
Thanks! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: