Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guide to migrate datastore to mysql post #1841

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@@ -106,7 +106,7 @@ Please note that the phases (Incubating, Alpha, Beta, and Stable) are applied to
| GitHub & GitHub Enterprise SSO | Beta |
| Google SSO | Incubating |
| Data Store - Support GCP [Firestore](https://cloud.google.com/firestore) | Beta |
| Data Store - Support [MongoDB](https://www.mongodb.com/) | Alpha ([deprecated](/blog/2021/04/01/migrate-control-plane-datastore-to-mysql/)) |
| Data Store - Support [MongoDB](https://www.mongodb.com/) | Alpha ([deprecated](/blog/2021/04/01/migrate-control-plane-datastore-from-mongodb-to-mysql)) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the link path is still migrate-control-plane-datastore-to-mysql because it's based on the markdown file name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used to think like you too 😂 But tested with the new link 😁

Copy link
Member

@nakabonne nakabonne Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? A little bit odd 🤔
I don't know but someone may be subscribing to this blog and bookmark this page. We want to avoid the link change as much as possible. but well, It's on you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right 👍 I unchanged the link to that post 🙏

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot added size/XS and removed size/S labels Apr 9, 2021
@nghialv
Copy link
Member

nghialv commented Apr 9, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nakabonne
Copy link
Member

Okay, our hugo builds the link based on the post's title, huh. I feel it can be changed but good enough to be this 👍
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Apr 9, 2021
@khanhtc1202
Copy link
Member Author

Okay, our hugo builds the link based on the post's title, huh. I feel it can be changed but good enough to be this 👍

Sure, will check the Hugo link build logic later for that kind of issue 🙏

@nakabonne
Copy link
Member

Thanks!

@pipecd-bot pipecd-bot merged commit 676cb08 into master Apr 9, 2021
@pipecd-bot pipecd-bot deleted the update-docs branch April 9, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants