Add installation guide for namespaced mode #1840
Conversation
|
Code coverage for golang is |
| See [values.yaml](https://github.com/pipe-cd/manifests/blob/master/manifests/piped/values.yaml) for the full values. | ||
|
|
||
| ### Installing on Kubernetes cluster in the namespaced mode | ||
| The previous way requires installing cluster-level resources. If you want to restrict Piped's permission within the namespace as the same as Piped, this way is for you. |
There was a problem hiding this comment.
nits,
The previous way requires installing Piped as cluster-level resource.
There was a problem hiding this comment.
For sure, but honestly I don't know exactly which is better. Most of Piped resources are namespace-level then only Role/ClusterRole and RoleBindings/ClusterRoleBindings can be different, that's why I thought "installing cluster-level resources" is kind of suitable for it. No strong opinion though 😃
There was a problem hiding this comment.
I get your point 👍 then keep it as is LGTM 🙆♀️ I don't have a strong objection to this
|
/lgtm |
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
/changelog |
|
@nghialv: Changelog has been generated in response to this comment. DetailsChangelog since v0.9.10Notable ChangesInternal Changes
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Ref: #1830
Does this PR introduce a user-facing change?: