-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a web RPC to update the description of application #1842
Conversation
🙆♂️ |
Code coverage for golang is
|
pkg/app/api/grpcapi/web_api.go
Outdated
app.PipedId = req.PipedId | ||
app.Kind = req.Kind | ||
app.CloudProvider = req.CloudProvider | ||
app.Description = req.Description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UpdateApplicationRequest.Description
is added right before, isn't it? If so I think we can sneaky remove it. Or, still it's needed for somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Let me remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
Thank you. There you go! |
Code coverage for golang is
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: