Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupport pipectl datastore command #1843

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Unsupport pipectl datastore command #1843

merged 1 commit into from
Apr 9, 2021

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Disable pipectl datastore command

@pipecd-bot
Copy link
Collaborator

DOCKER

Unabled to get changed files of pull request.

Details 
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

KAPETANIOS

Failed while validating Kapetanios configuration.

Details 
Error: rpc error: code = NotFound desc = not found

@nakabonne
Copy link
Member

What's up, Kapetanos

@nakabonne
Copy link
Member

/kapetanios reload

@pipecd-bot
Copy link
Collaborator

KAPETANIOS

@nakabonne: Successfully loaded the latest Kapetanios configuration.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

This one is for pagination stuff right. Good job 👍
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Apr 9, 2021
@nghialv
Copy link
Member

nghialv commented Apr 9, 2021

Actually, this /kapetanios reload command does not help in this case. That is only for reloading the newly merged Kapetanios configuration changes. Those errors were caused due to Kapetanios itself, not Kapetanios' configuration.

@khanhtc1202
Copy link
Member Author

This one is for pagination stuff right.

Yep, it's preparation for the datastore interface changes (allow pagination). I'm going to remove MongoDB completely from our code base again 😂

@nghialv
Copy link
Member

nghialv commented Apr 9, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 0824372 into master Apr 9, 2021
@pipecd-bot pipecd-bot deleted the disable-datastore-command branch April 9, 2021 08:34
@nakabonne
Copy link
Member

Actually, this /kapetanios reload command does not help in this case.

It actually is. We gotta look into why.

@pipecd-bot pipecd-bot mentioned this pull request Apr 12, 2021
Merged
@khanhtc1202 khanhtc1202 mentioned this pull request Apr 12, 2021
Merged
pipecd-bot pushed a commit that referenced this pull request Apr 12, 2021
@khanhtc1202
Remove unnecessary defined MigratableModel list (#1849)
9954b9f 
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Follow #1843 

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved area/pipectl lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khanhtc1202 @pipecd-bot @nakabonne @nghialv