Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some styles for laptop screens #1977

Merged
merged 1 commit into from May 20, 2021
Merged

Fix some styles for laptop screens #1977

merged 1 commit into from May 20, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented May 19, 2021

What this PR does / why we need it:

  • Fix a bug that prevented the settings page from scrolling on small screens
  • Adjust text size
  • Adjust the Deployment Detail style

Before

image

image

After

image

image

Which issue(s) this PR fixes:

Fixes #1935

Does this PR introduce a user-facing change?:

Fix broken layout at some pages on small screens

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.51%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.66%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented May 20, 2021

/lgtm

@khanhtc1202
Copy link
Member

Nice 🙌
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A couple of pages look unsuitable for 13-inch screen
4 participants