-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that primary workloads should be restarted when its config was updated #2054
Conversation
Code coverage for golang is |
Code coverage for golang is |
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Change the way to detect whether an APIVersion is built-in or notThis was created by todo plugin since "TODO:" was found in 49e67d3 when #2054 was merged. cc: @nghialv.2. Anotate config hash into other workload kinds such as DaemonSet, StatefulSet...This was created by todo plugin since "TODO:" was found in 49e67d3 when #2054 was merged. cc: @nghialv. |
Code coverage for golang is |
Way to go 🚀 |
/changelog |
@nghialv: Changelog has been generated in response to this comment. DetailsChangelog since v0.9.15Notable Changes
Internal Changes
|
What this PR does / why we need it:
This PR ensures that all workload resources (Deployment) will have an additional annotation
pipecd.dev/config-hash
with the value is the hash of its referencing congimaps/secrets.This adding makes all workloads to be restarted automatically when one of its configs was changed.
About the drift detector, it is ignoring all added labels/annotations so no diff will be introduced by this adding.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: