Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for PipeCD ECS Application #1998

Merged
merged 6 commits into from May 27, 2021
Merged

RFC for PipeCD ECS Application #1998

merged 6 commits into from May 27, 2021

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented May 25, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Related to #1568

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.93%. This pull request increases coverage by 0.07%.

File Function Base Head Diff
pkg/app/api/grpcapi/web_api.go WebAPI.GetInsightApplicationCount 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/applications.go Collector.updateApplicationCounts 0.00% 0.00% +0.00%
pkg/insight/applicationcount.go MakeApplicationCounts 0.00% 100.00% +100.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.93%. This pull request increases coverage by 0.07%.

File Function Base Head Diff
pkg/app/api/grpcapi/web_api.go WebAPI.GetInsightApplicationCount 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/applications.go Collector.updateApplicationCounts 0.00% 0.00% +0.00%
pkg/insight/applicationcount.go MakeApplicationCounts 0.00% 100.00% +100.00%

@nakabonne
Copy link
Member

Looks cool
/lgtm

with:
canary: 100
```

Copy link
Member

@nghialv nghialv May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more examples for quick sync, canary, blue-green. That helps us evaluating the definition of stages easier.

@khanhtc1202
Copy link
Member Author

@nghialv @nakabonne thanks for your comment 🙏 I added some pipe yaml config examples for canary and blue/green release deployment, PTAL 👀

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.93%. This pull request increases coverage by 0.07%.

File Function Base Head Diff
pkg/app/api/grpcapi/web_api.go WebAPI.GetInsightApplicationCount 0.00% 0.00% +0.00%
pkg/app/ops/insightcollector/applications.go Collector.updateApplicationCounts 0.00% 0.00% +0.00%
pkg/insight/applicationcount.go MakeApplicationCounts 0.00% 100.00% +100.00%

@nghialv
Copy link
Member

nghialv commented May 26, 2021

👀

@nghialv
Copy link
Member

nghialv commented May 27, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 5890c91 into master May 27, 2021
@pipecd-bot pipecd-bot deleted the ecs-rfc branch May 27, 2021 05:55
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule manifests

Details
Error: unabled to render file: manifests/pipecd/prom-rules/alerting_rules.yml, err: template: template-plugin:11: undefined variable "$labels"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants