Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter deleted env to show only active environments on the web #2044

Merged
merged 1 commit into from Jun 4, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jun 3, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix showing deleted environments on deployments/applications' filter list

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.32%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.96%. This pull request increases coverage by 0.57%.

File Base Head Diff
src/components/add-env-form/index.tsx -- 46.67% +46.67%
src/components/environment-list-item/edit-dialog.tsx -- 77.78% +77.78%
src/components/environment-list-item/index.tsx -- 88.89% +88.89%
src/pages/settings/environment/index.tsx -- 85.29% +85.29%
src/pages/settings/environment/components/delete-confirm-dialog/index.tsx -- 96.55% +96.55%
src/fixtures/dummy-environment.ts 100.00% 100.00% +0.00%
src/api/environments.ts 70.59% 88.24% +17.65%
src/middlewares/thunk-error-handler.ts 86.67% 93.33% +6.67%
src/mocks/services/environment.ts 57.14% 100.00% +42.86%
src/modules/applications.ts 90.48% 95.24% +4.76%
src/modules/deleting-env.ts 52.94% 76.47% +23.53%
src/modules/environments.ts 84.00% 96.15% +12.15%
test-utils.tsx 100.00% 100.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.32%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.96%. This pull request decreases coverage by -0.01%.

File Base Head Diff
src/fixtures/dummy-environment.ts 100.00% 100.00% +0.00%
src/components/environment-list-item/index.tsx 91.67% 88.89% -2.78%
src/mocks/services/environment.ts 100.00% 100.00% +0.00%
src/modules/environments.ts 96.00% 96.15% +0.15%

@cakecatz cakecatz changed the title WIP: Filter deleted env to show only active environments on the web Filter deleted env to show only active environments on the web Jun 4, 2021
@cakecatz cakecatz marked this pull request as ready for review June 4, 2021 06:50
@nghialv
Copy link
Member

nghialv commented Jun 4, 2021

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jun 4, 2021
@khanhtc1202
Copy link
Member

Thanks 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants