Implement RPC to retrieve planpreview results #2121
Conversation
|
The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by You can check the build log from here. |
|
Code coverage for golang is
|
|
/lgtm |
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // TODO: Implement GetPlanPreviewResults RPC. | ||
| const freshDuration = 24 * time.Hour |
There was a problem hiding this comment.
Is it really needed to be in the block? I feel it should be out of there.
There was a problem hiding this comment.
👍
The command output contains the diff generated by our drift detector or external tools like terraform.
Of course, we are masking sensitive data while comparing but just in case.
So we can think of this as an additional safety guard.
There was a problem hiding this comment.
Sorry, what I mean was this const freshDurations should be out of this function block.
There was a problem hiding this comment.
Ah, I misunderstood what you wanted to say.
I think we should put it inside that function to strict its scope. It must only be used by that function, no one else.
| // Additional data to be stored in filestore. | ||
| bytes data = 5; | ||
| // Additional output data to be stored in filestore. | ||
| bytes output = 5; |
There was a problem hiding this comment.
Okay, currently nothing uses the Data field 👍
|
There you go. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2107
Fixes #2108
Does this PR introduce a user-facing change?: