Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the additional data of command into the filestore before marking the command as handled. #2108

Closed
pipecd-bot opened this issue Jun 22, 2021 · 0 comments · Fixed by #2121
Closed

Store the additional data of command into the filestore before marking the command as handled. #2108

pipecd-bot opened this issue Jun 22, 2021 · 0 comments · Fixed by #2121
Assignees
@nghialv
Labels
area/api kind/todo

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/9d0379c0039aa041ca7c280e471bdcb881c3edb8/pkg/app/api/grpcapi/piped_api.go#L619-L622

This was created by todo plugin since "TODO:" was found in 9d0379c when #2105 was merged. cc: @nghialv.
@nghialv nghialv mentioned this issue Jun 24, 2021
Merged
pipecd-bot pushed a commit that referenced this issue Jun 24, 2021
@nghialv
Implement RPC to retrieve planpreview results (#2121)
c7f3d17 
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #2107
Fixes #2108 

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghialv nghialv

Labels
area/api kind/todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement RPC to retrieve planpreview results pipe-cd/pipecd
2 participants
@nghialv @pipecd-bot