Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to deploy Kubernetes application to the specified namespace #213

Merged
merged 1 commit into from Jun 26, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jun 26, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Add namespace for generated resources.

https://github.com/pipe-cd/pipe/blob/8a201eab0f14a2d29289b29f01f9395fb78d1b11/pkg/app/piped/executor/kubernetes/canary.go#L141-L144

This was created by todo plugin since "TODO:" was found in 8a201ea when #213 was merged. cc: @nghialv.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 25.84%. This pull request decreases coverage by -0.03%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Apply 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubectl.go Kubectl.Delete 0.00% 0.00% +0.00%

@stormcat24
Copy link
Contributor

/apporve

@stormcat24
Copy link
Contributor

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by stormcat24.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit e218d6e into master Jun 26, 2020
@pipecd-bot pipecd-bot deleted the piped branch June 26, 2020 02:46
This was referenced Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants