Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apiregistration.k8s.io/* API to the default watching list of Kubernetes #2438

Merged
merged 3 commits into from Oct 1, 2021

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Sep 9, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes part of #2436

Does this PR introduce a user-facing change?:

NONE

@ono-max ono-max changed the title Add apiregistration.k8s.io/* API to the default watching list of Kube… Add apiregistration.k8s.io/* API to the default watching list of Kubernetes Sep 9, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.39%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.39%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Sep 9, 2021

/hold

@nghialv nghialv closed this Sep 13, 2021
@ono-max ono-max deleted the add-resource branch September 22, 2021 00:28
@ono-max ono-max restored the add-resource branch October 1, 2021 06:35
@ono-max ono-max reopened this Oct 1, 2021
@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/piped/executor/analysis/mannwhitney/udist.go
--- pkg/app/piped/executor/analysis/mannwhitney/udist.go.orig
+++ pkg/app/piped/executor/analysis/mannwhitney/udist.go
@@ -228,7 +228,7 @@
 	// bounds. It might be worth turning these into directly
 	// indexible slices.
 	A := make([]map[ukey]float64, K+1)
-	A[K] = map[ukey]float64{ukey{n1: n1, twoU: twoU}: 0}
+	A[K] = map[ukey]float64{{n1: n1, twoU: twoU}: 0}
 
 	// Compute memo table (k, n1, twoU) triples from high K values
 	// to low K values. This drives the recurrence relation

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.37%. This pull request does not change code coverage.

@ono-max
Copy link
Member Author

ono-max commented Oct 1, 2021

/golinter fmt

@pipecd-bot
Copy link
Collaborator

GO_LINTER

Unabled to format the unfmt-ed files. In response to this comment.

@ono-max
Copy link
Member Author

ono-max commented Oct 1, 2021

/hold cancel

@nghialv
Copy link
Member

nghialv commented Oct 1, 2021

I am not sure whether GKE Autopilot is allowing this or not. But let's merge and check against it.
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Oct 1, 2021
@khanhtc1202
Copy link
Member

Way to go
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants