New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apiregistration.k8s.io/* API to the default watching list of Kubernetes #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
changed the title
Add apiregistration.k8s.io/* API to the default watching list of Kube…
Add apiregistration.k8s.io/* API to the default watching list of Kubernetes
Sep 9, 2021
ono-max
force-pushed
the
add-resource
branch
from
September 9, 2021 00:22
471f1df
to
61dbda6
Compare
/hold |
The following files are not gofmt-ed. By commenting pkg/app/piped/executor/analysis/mannwhitney/udist.go--- pkg/app/piped/executor/analysis/mannwhitney/udist.go.orig
+++ pkg/app/piped/executor/analysis/mannwhitney/udist.go
@@ -228,7 +228,7 @@
// bounds. It might be worth turning these into directly
// indexible slices.
A := make([]map[ukey]float64, K+1)
- A[K] = map[ukey]float64{ukey{n1: n1, twoU: twoU}: 0}
+ A[K] = map[ukey]float64{{n1: n1, twoU: twoU}: 0}
// Compute memo table (k, n1, twoU) triples from high K values
// to low K values. This drives the recurrence relation
|
/golinter fmt |
Unabled to format the unfmt-ed files. In response to this comment. |
/hold cancel |
I am not sure whether GKE Autopilot is allowing this or not. But let's merge and check against it. |
Way to go |
This was referenced Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes part of #2436
Does this PR introduce a user-facing change?: