Add new option to run all deployments with specified pipeline #2470
Conversation
|
Code coverage for golang is
|
|
nice |
| @@ -125,6 +125,14 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu | |||
| return | |||
| } | |||
|
|
|||
| // Force to use pipeline when the alwaysUsePipeline field was configured. | |||
| if cfg.Planner.AlwaysUsePipeline { | |||
There was a problem hiding this comment.
Should we add TODO or something in planner for other kinds of deployment we're supporting? Since this configuration is added as GenericDeploymentSpec config.
There was a problem hiding this comment.
I have checked all other kinds and actually we don't need to have any additional updates for them.
There was a problem hiding this comment.
On the second thought, let me add this part for them too. For good consistency.
There was a problem hiding this comment.
Yeh, that's what I worried about. Since this configuration may lead users to think like they have to add this line in their configuration for all kinds of applications.
There was a problem hiding this comment.
I have just applied this new field to all application kinds. PTAL.
|
/hold |
|
/hold cancel |
|
Code coverage for golang is
|
|
/lgtm |
|
Nice |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: