Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update planner to use pipeline even for the first deployment when alwaysUsePipeline was configured #2472

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Sep 13, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv nghialv changed the title Update planner to use pipeline even for the first deployment when alw… Update planner to use pipeline even for the first deployment when alwaysUsePipeline was configured Sep 13, 2021
@nakabonne
Copy link
Member

/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.37%. This pull request does not change code coverage.

@@ -81,6 +81,14 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu
return
}

// Force to use pipeline when the alwaysUsePipeline field was configured.
Copy link
Member

@khanhtc1202 khanhtc1202 Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, how about moving the check to perform QuickSync in case of no pipeline configured at line L101 above this block and remove cfg.Pipeline != nil condition check?
Of course, it's up to you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Nice catch! 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanhtc1202 Applied your suggestion!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@@ -81,6 +81,14 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu
return
}

// Force to use pipeline when the alwaysUsePipeline field was configured.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pipecd-bot pipecd-bot removed the lgtm label Sep 13, 2021
@khanhtc1202
Copy link
Member

Nice
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 8f074f0 into master Sep 13, 2021
@pipecd-bot pipecd-bot deleted the planner branch September 13, 2021 09:40
@nghialv
Copy link
Member Author

nghialv commented Sep 13, 2021

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.16.0

Notable Changes

No notable changes for this release

Internal Changes

  • Update planner to use pipeline even for the first deployment when alwaysUsePipeline was configured (#2472)
  • Add an RFC for dynamic ADA (#2385)
  • Provisioned dashboards version update (#2471)
  • Add new option to run all deployments with specified pipeline (#2470)
  • Fix datasource not found for provisioned dashboards (#2469)
  • Insert new lines in pkg/app/piped/controller/scheduler.go to consolidate the format (#2467)
  • Reset grafana provisioning board id (#2466)
  • Fix typo (#2463)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants