Update planner to use pipeline even for the first deployment when alwaysUsePipeline was configured #2472
Conversation
…aysUsePipeline was configured
nghialv
changed the title
|
/lgtm |
|
Code coverage for golang is |
pkg/app/piped/planner/ecs/ecs.go
Outdated
| @@ -81,6 +81,14 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu | |||
| return | |||
| } | |||
|
|
|||
| // Force to use pipeline when the alwaysUsePipeline field was configured. | |||
There was a problem hiding this comment.
nits, how about moving the check to perform QuickSync in case of no pipeline configured at line L101 above this block and remove cfg.Pipeline != nil condition check?
Of course, it's up to you.
There was a problem hiding this comment.
@khanhtc1202 Applied your suggestion!
| @@ -81,6 +81,14 @@ func (p *Planner) Plan(ctx context.Context, in planner.Input) (out planner.Outpu | |||
| return | |||
| } | |||
|
|
|||
| // Force to use pipeline when the alwaysUsePipeline field was configured. | |||
There was a problem hiding this comment.
|
Nice |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
/changelog |
|
@nghialv: Changelog has been generated in response to this comment. DetailsChangelog since v0.16.0Notable ChangesNo notable changes for this release Internal Changes
|
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: