Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empower Piped to change how often to sync app config in Git #2833

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:
Since an application config file is updated much less frequently than the deployment frequency, the settings should be separated.

Which issue(s) this PR fixes:

Fixes #2809

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Add doc for appConfigSyncInterval -->

https://github.com/pipe-cd/pipe/blob/4fdc66ba9bff8ce9e650d937c1a1e2acd4bf56e0/docs/content/en/docs-dev/operator-manual/piped/configuration-reference.md#L28-L31

This was created by todo plugin since "TODO:" was found in 4fdc66b when #2833 was merged. cc: @nakabonne.

@khanhtc1202
Copy link
Member

Something big has come 😌
/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.79%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/config/config.go Kind.ToApplicationKind -- 100.00% +100.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo 75.00% 73.33% -1.67%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by ono-max.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Think about sync interval of app config reporter
4 participants