Add options to filter piped list #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakecatz
reviewed
Jul 8, 2020
| // Whether to include the status value in the response message. | ||
| bool with_status = 1; | ||
| Options options = 2; |
There was a problem hiding this comment.
Optionsでラップしなくても良い気がするんですけど、サーバサイド的にこっちが楽だったりしますか？
There was a problem hiding this comment.
YAGNI(You aren't going need it)かもしれませんが、フィルタリングに使用するフィールドが増えることを想定して、他のフィルタリングと同じようにラップしてます。
|
Code coverage for golang is |
|
/approve |
1 similar comment
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of #317
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: