Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to filter piped list #340

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Add options to filter piped list #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/app/api/service/webservice/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,12 @@ message DisablePipedResponse {
}

message ListPipedsRequest {
message Options {
bool include_disabled = 1;
}
// Whether to include the status value in the response message.
bool with_status = 1;
Options options = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionsでラップしなくても良い気がするんですけど、サーバサイド的にこっちが楽だったりしますか？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAGNI(You aren't going need it)かもしれませんが、フィルタリングに使用するフィールドが増えることを想定して、他のフィルタリングと同じようにラップしてます。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解です！

}

message ListPipedsResponse {
Expand Down