Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist and load the start time of wait stage to deal with restart case #348

Merged
merged 2 commits into from Jul 9, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 9, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #125

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jul 9, 2020

/cc @nakabonne

@pipecd-bot pipecd-bot requested review from nakabonne and removed request for cakecatz July 9, 2020 03:07
@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/piped/executor/wait/wait.go
--- pkg/app/piped/executor/wait/wait.go.orig
+++ pkg/app/piped/executor/wait/wait.go
@@ -20,9 +20,10 @@
 	"strconv"
 	"time"
 
+	"go.uber.org/zap"
+
 	"github.com/pipe-cd/pipe/pkg/app/piped/executor"
 	"github.com/pipe-cd/pipe/pkg/model"
-	"go.uber.org/zap"
 )
 
 const (

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 24.23%. This pull request decreases coverage by -0.13%.

File Function Base Head Diff
pkg/app/piped/executor/wait/wait.go Executor.retrieveStartTime -- 0.00% +0.00%
pkg/app/piped/executor/wait/wait.go Executor.saveStartTime -- 0.00% +0.00%
pkg/app/piped/executor/wait/wait.go Executor.Execute 0.00% 0.00% +0.00%

@nghialv
Copy link
Member Author

nghialv commented Jul 9, 2020

/golinter fmt

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 24.23%. This pull request decreases coverage by -0.13%.

File Function Base Head Diff
pkg/app/piped/executor/wait/wait.go Executor.retrieveStartTime -- 0.00% +0.00%
pkg/app/piped/executor/wait/wait.go Executor.saveStartTime -- 0.00% +0.00%
pkg/app/piped/executor/wait/wait.go Executor.Execute 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 015c764 into master Jul 9, 2020
@pipecd-bot pipecd-bot deleted the wait branch July 9, 2020 04:31
@pipecd-bot pipecd-bot mentioned this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist and load the start time to deal with restart case.
3 participants