Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist and load the start time to deal with restart case. #125

Closed
pipecd-bot opened this issue Jun 21, 2020 · 0 comments · Fixed by #348
Closed

Persist and load the start time to deal with restart case. #125

pipecd-bot opened this issue Jun 21, 2020 · 0 comments · Fixed by #348
Assignees
@nghialv
Labels
area/piped kind/todo priority/P2
Projects
v1.alpha

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/4df6a870e92095686ea8181f1e2dc4673a21798c/pkg/app/piped/executor/wait/wait.go#L46-L49

This was created by todo plugin since "TODO:" was found in 4df6a87 when #122 was merged. cc: @nghialv.
@project-bot project-bot bot added this to To do in Prototype Jun 21, 2020
@nghialv nghialv added this to To do in v1.alpha via automation Jul 7, 2020
@nghialv nghialv removed this from To do in Prototype Jul 7, 2020
@nghialv nghialv mentioned this issue Jul 9, 2020
Merged
v1.alpha automation moved this from To do to Done Jul 9, 2020
pipecd-bot pushed a commit that referenced this issue Jul 9, 2020
@nghialv
Persist and load the start time of wait stage to deal with restart ca…
015c764 
…se (#348)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #125

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
@nghialv nghialv self-assigned this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghialv nghialv

Labels
area/piped kind/todo priority/P2
Projects
No open projects
v1.alpha
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Persist and load the start time of wait stage to deal with restart case pipe-cd/pipecd
2 participants
@nghialv @pipecd-bot