Add todo for health state checks #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Check health state of CronJob resourceThis was created by todo plugin since "TODO:" was found in 285525c when #354 was merged. cc: @nakabonne.2. Check health state of PersistentVolume resourceThis was created by todo plugin since "TODO:" was found in 285525c when #354 was merged. cc: @nakabonne. |
pipecd-bot
reviewed
Jul 9, 2020
| @@ -286,6 +290,12 @@ func determineReplicaSetHealth(obj *unstructured.Unstructured) (status model.Kub | |||
| return | |||
| } | |||
|
|
|||
| // TODO: Check health state of CronJob resource | |||
| func determineCronJobHealth(obj *unstructured.Unstructured) (status model.KubernetesResourceState_HealthStatus, desc string) { | |||
There was a problem hiding this comment.
obj is unused in determineCronJobHealth
| @@ -434,6 +444,12 @@ func determineSecretHealth(obj *unstructured.Unstructured) (status model.Kuberne | |||
| return | |||
| } | |||
|
|
|||
| // TODO: Check health state of PersistentVolume resource | |||
| func determinePersistentVolumeHealth(obj *unstructured.Unstructured) (status model.KubernetesResourceState_HealthStatus, desc string) { | |||
There was a problem hiding this comment.
obj is unused in determinePersistentVolumeHealth
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for golang is
|
This was referenced Jul 9, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: