Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Deployment filter #367

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Support for Deployment filter #367

merged 1 commit into from
Jul 10, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #366

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Support pagination for Deployment list

https://github.com/pipe-cd/pipe/blob/41ad7d52738460d04f0f00f6601eb1f989835808/pkg/app/api/api/web_api.go#L435-L438

This was created by todo plugin since "TODO:" was found in 41ad7d5 when #367 was merged. cc: @nakabonne.

2. Support IN Query filter for Deployments fields

https://github.com/pipe-cd/pipe/blob/41ad7d52738460d04f0f00f6601eb1f989835808/pkg/app/api/api/web_api.go#L444-L447

This was created by todo plugin since "TODO:" was found in 41ad7d5 when #367 was merged. cc: @nakabonne.

@nakabonne
Copy link
Member Author

/cc @cakecatz

@pipecd-bot pipecd-bot requested a review from cakecatz July 10, 2020 07:59
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.87%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jul 10, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update web.ListDeployments to support filters
3 participants