Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use duration string #449

Merged
merged 2 commits into from Jul 16, 2020
Merged

Use duration string #449

merged 2 commits into from Jul 16, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.91%. This pull request does not change code coverage.

@@ -218,7 +218,7 @@ func retryCommand(retries int, interval time.Duration, logger *zap.Logger, comma
if err == nil {
return
}
logger.Warn(fmt.Sprintf("command was failed %d times, sleep %d seconds before retrying command", i+1, interval))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or %v

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That more makes sense than calling String().

@pipecd-bot
Copy link
Collaborator

COMMIT_MESSAGE

There are INVALID COMMIT MESSAGES on this pull request:

Details

All commit messages must match the defined regular expression:

^[A-Z\[]

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@nghialv
Copy link
Member

nghialv commented Jul 16, 2020

/approve

@nakabonne
Copy link
Member Author

/golinter trigger

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.91%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit a43970e into master Jul 16, 2020
@pipecd-bot pipecd-bot deleted the use-string branch July 16, 2020 08:34
@pipecd-bot pipecd-bot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants