Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use duration string #449

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Use duration string #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9515103
Use duration string
nakabonne Jul 16, 2020
9b1b8d2
Use %v
nakabonne Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/git/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func retryCommand(retries int, interval time.Duration, logger *zap.Logger, comma
if err == nil {
return
}
logger.Warn(fmt.Sprintf("command was failed %d times, sleep %d seconds before retrying command", i+1, interval))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or %v

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That more makes sense than calling String().

logger.Warn(fmt.Sprintf("command was failed %d times, sleep %v before retrying command", i+1, interval))
time.Sleep(interval)
}
return
Expand Down