Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a module to manage project info #490

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Create a module to manage project info #490

merged 1 commit into from
Jul 20, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #462

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Use fetched project name

https://github.com/pipe-cd/pipe/blob/37d3bfedec219f8072a16e6eb776c3e7a1754e30/pkg/app/web/src/modules/project.ts#L8-L11

This was created by todo plugin since "TODO:" was found in 37d3bfe when #490 was merged. cc: @cakecatz.

@nghialv
Copy link
Member

nghialv commented Jul 20, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.93%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 789a86f into master Jul 20, 2020
@pipecd-bot pipecd-bot deleted the project-module branch July 20, 2020 06:33
This was referenced Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use correct project name
3 participants