Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the auth handler to api server #492

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Added the auth handler to api server #492

merged 3 commits into from
Jul 20, 2020

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Jul 20, 2020

What this PR does / why we need it:

  • This PR is for debugging password authentification.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@gkuga
Copy link
Contributor Author

gkuga commented Jul 20, 2020

/trigger build

@pipecd-bot
Copy link
Collaborator

TRIGGER

@gkuga: Your requested build has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.93%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.93%. This pull request does not change code coverage.

@nghialv nghialv changed the title Added a auth handler to api server Added the auth handler to api server Jul 20, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 22.93%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jul 20, 2020

やばい、今までずっと piped のmanifestだと思って、確認して、レビューしました。これは pipecd のmanifestですね

@gkuga
Copy link
Contributor Author

gkuga commented Jul 20, 2020

やばい、今までずっと piped のmanifestだと思って、確認して、レビューしました。これは pipecd のmanifestですね

そうですwとりあえず、piped-secretと同じ感じになったと思いますが、configmap.yamlで指定しているマウント部分がどうしようかなと考えてます。configmap.yamlというかvaluesですね。

https://github.com/pipe-cd/pipe/blob/master/manifests/pipecd/values.yaml#L72

@nghialv
Copy link
Member

nghialv commented Jul 20, 2020

一応、マージしましょうか。後で、secret, configmap周り整理しましょう。

@nghialv
Copy link
Member

nghialv commented Jul 20, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 739e0e2 into master Jul 20, 2020
@pipecd-bot pipecd-bot deleted the signing-key branch July 20, 2020 09:02
@pipecd-bot pipecd-bot mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants