Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split deployment configuration into multiple files #560

Merged
merged 2 commits into from Jul 29, 2020
Merged

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jul 29, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Add a validate to ensure this was configured or using the default value by service name.

https://github.com/pipe-cd/pipe/blob/a5cd14bad17992c17564443a3b4c2219c5153d3a/pkg/config/deployment_kubernetes.go#L116-L119

This was created by todo plugin since "TODO:" was found in a5cd14b when #560 was merged. cc: @nghialv.

@nghialv
Copy link
Member Author

nghialv commented Jul 29, 2020

/cc @nakabonne

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

pkg/config/deployment_kubernetes.go Show resolved Hide resolved
@nghialv
Copy link
Member Author

nghialv commented Jul 29, 2020

/todo skip

pkg/config/deployment_kubernetes.go Outdated Show resolved Hide resolved
pkg/config/deployment_kubernetes.go Outdated Show resolved Hide resolved
Co-authored-by: Ryo Nakao <ryo@nakao.dev>
@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.76%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.Validate -- 100.00% +100.00%
pkg/config/deployment_kubernetes.go DetermineTrafficRoutingMethod -- 0.00% +0.00%
pkg/config/deployment_kubernetes.go K8sTrafficRoutingStageOptions.Percentages -- 0.00% +0.00%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/config/deployment_terraform.go TerraformDeploymentSpec.Validate -- 100.00% +100.00%
pkg/config/deployment.go KubernetesDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment.go KubernetesDeploymentSpec.Validate 100.00% -- -100.00%
pkg/config/deployment.go TerraformDeploymentSpec.GetStage 0.00% -- +-0.00%
pkg/config/deployment.go TerraformDeploymentSpec.Validate 100.00% -- -100.00%
pkg/config/deployment.go DetermineTrafficRoutingMethod 0.00% -- +-0.00%
pkg/config/deployment.go K8sTrafficRoutingStageOptions.Percentages 0.00% -- +-0.00%

@pipecd-bot pipecd-bot merged commit 1df7326 into master Jul 29, 2020
@pipecd-bot pipecd-bot deleted the refactor branch July 29, 2020 08:27
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants