Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for GCS #806

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Add test cases for GCS #806

merged 2 commits into from
Sep 15, 2020

Conversation

nakabonne
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #801

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.47%. This pull request increases coverage by 0.24%.

File Function Base Head Diff
pkg/filestore/gcs/gcs.go Store.GetObject 71.43% 78.57% +7.14%
pkg/filestore/gcs/gcs.go Store.PutObject 0.00% 57.14% +57.14%
pkg/filestore/gcs/gcs.go Store.ListObjects 0.00% 84.62% +84.62%
pkg/filestore/gcs/gcs.go Store.Close 0.00% 100.00% +100.00%
pkg/filestore/gcs/gcs.go Store.NewReader 42.86% 71.43% +28.57%

Host: "127.0.0.1",
Port: 8081,
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Remove empty line.

@nakabonne
Copy link
Member Author

Fixed

@nghialv
Copy link
Member

nghialv commented Sep 15, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.47%. This pull request increases coverage by 0.24%.

File Function Base Head Diff
pkg/filestore/gcs/gcs.go Store.NewReader 42.86% 71.43% +28.57%
pkg/filestore/gcs/gcs.go Store.GetObject 71.43% 78.57% +7.14%
pkg/filestore/gcs/gcs.go Store.PutObject 0.00% 57.14% +57.14%
pkg/filestore/gcs/gcs.go Store.ListObjects 0.00% 84.62% +84.62%
pkg/filestore/gcs/gcs.go Store.Close 0.00% 100.00% +100.00%

@nakabonne
Copy link
Member Author

/trigger build

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nakabonne: Your requested build has been scheduled in response to this comment.

@nakabonne
Copy link
Member Author

/trigger test

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nakabonne: Your requested test has been scheduled in response to this comment.

@nakabonne
Copy link
Member Author

/trigger build

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nakabonne: Your requested build has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.47%. This pull request increases coverage by 0.24%.

File Function Base Head Diff
pkg/filestore/gcs/gcs.go Store.PutObject 0.00% 57.14% +57.14%
pkg/filestore/gcs/gcs.go Store.ListObjects 0.00% 84.62% +84.62%
pkg/filestore/gcs/gcs.go Store.Close 0.00% 100.00% +100.00%
pkg/filestore/gcs/gcs.go Store.NewReader 42.86% 71.43% +28.57%
pkg/filestore/gcs/gcs.go Store.GetObject 71.43% 78.57% +7.14%

@nakabonne
Copy link
Member Author

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nakabonne nakabonne merged commit 8fec33c into master Sep 15, 2020
@pipecd-bot pipecd-bot deleted the gcs-test-cases branch September 15, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for GCS
3 participants