Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use srcset for the images at landing page #821

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@cakecatz cakecatz changed the title Use srcset for core value images Use srcset for some imgaes Sep 17, 2020
@nghialv
Copy link
Member

nghialv commented Sep 17, 2020

/trigger build

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested build has been scheduled in response to this comment.

@nghialv
Copy link
Member

nghialv commented Sep 17, 2020

/trigger test

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested test has been scheduled in response to this comment.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.56%. This pull request does not change code coverage.

@nghialv nghialv changed the title Use srcset for some imgaes Use srcset for the images at landing page Sep 17, 2020
@nghialv
Copy link
Member

nghialv commented Sep 17, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 452d906 into master Sep 17, 2020
@pipecd-bot pipecd-bot deleted the responsive-image branch September 17, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants