New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interfaces for Image Watcher #902
Conversation
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Emit logThis was created by todo plugin since "FIXME:" was found in ca360fc when #902 was merged. cc: @nakabonne. |
/todo skip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type imageRepo struct { | ||
} | ||
|
||
func NewWatcher(interval time.Duration, logger *zap.Logger) Watcher { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger
is unused in NewWatcher
@@ -2,7 +2,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library") | |||
|
|||
go_library( | |||
name = "go_default_library", | |||
srcs = ["registry.go"], | |||
importpath = "github.com/pipe-cd/pipe/pkg/app/piped/containerregistry", | |||
srcs = ["gcs.go"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: gcr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a big mistake.
/approve |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: