Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #922

Merged
merged 1 commit into from Oct 6, 2020
Merged

Fix typos #922

merged 1 commit into from Oct 6, 2020

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 6, 2020

What this PR does / why we need it:
Fix typos.

Which issue(s) this PR fixes:
n/a

Does this PR introduce a user-facing change?:

NONE

@tnir
docs: Fix typos
e6f6a95 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@pipecd-bot
Copy link
Collaborator

CLA

Welcome @tnir!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@pipe-cd pipe-cd deleted a comment from pipecd-bot Oct 6, 2020
@tnir
Copy link
Contributor Author

tnir commented Oct 6, 2020

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@nghialv
Copy link
Member

nghialv commented Oct 6, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@nghialv
Copy link
Member

nghialv commented Oct 6, 2020

Thank you very much!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv nghialv changed the title docs: Fix typos Fix typos Oct 6, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 23.95%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit b9c9799 into pipe-cd:master Oct 6, 2020
@tnir tnir deleted the typos branch October 6, 2020 10:36
@pipecd-bot pipecd-bot mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakecatz cakecatz Awaiting requested review from cakecatz

@nakabonne nakabonne Awaiting requested review from nakabonne

Assignees
No one assigned
Labels
approved area/docs area/site release-note-none size/XS trigger/needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tnir @pipecd-bot @nghialv