Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing namespace option to port-forward command #941

Merged
merged 1 commit into from Oct 11, 2020
Merged

Add missing namespace option to port-forward command #941

merged 1 commit into from Oct 11, 2020

Conversation

butterv
Copy link
Contributor

@butterv butterv commented Oct 10, 2020 •
edited by nghialv

What this PR does / why we need it:
If namespace is specified in the helm install command, namespace should be specified in the kubectl port-forward command.

Which issue(s) this PR fixes:
Namespace is added to kubectl port-forward command.

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

CLA

Welcome @istsh!

Thanks for your contributing. It looks like this is your first PR to this repository 🎉. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Please read the CLA and leave a /cla sign comment on this pull request to sign the CLA.

@butterv
Copy link
Contributor Author

butterv commented Oct 10, 2020

/cla sign

@pipecd-bot
Copy link
Collaborator

CLA

Thank you for signing the CLA. Your signing has been successfully committed.

@nghialv
Copy link
Member

nghialv commented Oct 11, 2020

Nice catch! Thank you very much.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv
Copy link
Member

nghialv commented Oct 11, 2020

/trigger presubmits

@pipecd-bot
Copy link
Collaborator

TRIGGER

@nghialv: Your requested presubmits has been scheduled in response to this comment.

@nghialv nghialv changed the title Fix: add namespace option to port-forward command Add missing namespace option to port-forward command Oct 11, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 25.94%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot merged commit 8483927 into pipe-cd:master Oct 11, 2020
@butterv butterv deleted the fix-port-forward-command branch October 11, 2020 02:50
@pipecd-bot pipecd-bot mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakabonne nakabonne Awaiting requested review from nakabonne

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved area/docs area/site release-note-none size/XS trigger/needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@butterv @pipecd-bot @nghialv