Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the spec of sealed secret to provide better visibility in Git #975

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Oct 19, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #749

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Ensure that the output directory must be inside the application directory.

https://github.com/pipe-cd/pipe/blob/af811cf41ce09b9c0907ba361c38d677240ce1d5/pkg/app/piped/controller/controller.go#L652-L655

This was created by todo plugin since "TODO:" was found in af811cf when #975 was merged. cc: @nghialv.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 26.62%. This pull request increases coverage by 0.40%.

File Function Base Head Diff
pkg/config/sealed_secret.go SealedSecretSpec.RenderOriginalContent -- 92.31% +92.31%
pkg/app/piped/controller/controller.go decryptSealedSecrets 0.00% 79.31% +79.31%

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants