Skip to content

Commit

Permalink
Add a caution comment of scrape_interval (#4869)
Browse files Browse the repository at this point in the history
* Add caution comment of scrape_interval

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Remove concrete value

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

* Fix to commit hash of v0.47.0 to fix the ref position

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
  • Loading branch information
t-kikuc authored and khanhtc1202 committed Apr 22, 2024
1 parent ea90bc4 commit 1bb585d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions manifests/pipecd/templates/configmap.yaml
Expand Up @@ -200,6 +200,8 @@ data:
replacement: $1

- job_name: pipecd-ops
# This scrape_interval must not be larger than the interval of piped's stats-reporting.
# ref: https://github.com/pipe-cd/pipecd/blob/a73d0913643ef1da05bc8898cf055c9893f16e0b/pkg/app/piped/statsreporter/reporter.go#L53
scrape_interval: 1m
kubernetes_sd_configs:
- role: endpoints
Expand Down

0 comments on commit 1bb585d

Please sign in to comment.