Skip to content

Commit

Permalink
Make cookie insecure
Browse files Browse the repository at this point in the history
  • Loading branch information
nakabonne committed Sep 3, 2020
1 parent 60f2775 commit 580fb34
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions pkg/app/api/authhandler/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,12 @@ func (h *Handler) getProject(ctx context.Context, projectID string) (*model.Proj

func makeTokenCookie(value string) *http.Cookie {
return &http.Cookie{
Name: jwt.SignedTokenKey,
Value: value,
MaxAge: defaultTokenCookieMaxAge,
Path: rootPath,
Secure: true,
Name: jwt.SignedTokenKey,
Value: value,
MaxAge: defaultTokenCookieMaxAge,
Path: rootPath,
// TODO: Make cookie secure
//Secure: true,
HttpOnly: true,
SameSite: http.SameSiteLaxMode,
}
Expand Down

0 comments on commit 580fb34

Please sign in to comment.