Skip to content

Commit

Permalink
Revert "Temporarily disable appconfig reporter in Piped (#2868)"
Browse files Browse the repository at this point in the history
This reverts commit 585bfe7.
  • Loading branch information
nakabonne committed Dec 1, 2021
1 parent 1ab5997 commit 5aa9797
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 16 deletions.
1 change: 0 additions & 1 deletion pkg/app/piped/appconfigreporter/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ go_test(
srcs = ["appconfigreporter_test.go"],
embed = [":go_default_library"],
deps = [
"//pkg/config:go_default_library",
"//pkg/model:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@org_uber_go_zap//:go_default_library",
Expand Down
30 changes: 15 additions & 15 deletions pkg/app/piped/cmd/piped/piped.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import (
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/deploymentstore"
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/environmentstore"
"github.com/pipe-cd/pipe/pkg/app/piped/apistore/eventstore"
_ "github.com/pipe-cd/pipe/pkg/app/piped/appconfigreporter"
"github.com/pipe-cd/pipe/pkg/app/piped/appconfigreporter"
"github.com/pipe-cd/pipe/pkg/app/piped/chartrepo"
k8scloudprovidermetrics "github.com/pipe-cd/pipe/pkg/app/piped/cloudprovider/kubernetes/kubernetesmetrics"
"github.com/pipe-cd/pipe/pkg/app/piped/controller"
Expand Down Expand Up @@ -448,20 +448,20 @@ func (p *piped) run(ctx context.Context, input cli.Input) (runErr error) {
}

// Start running app-config-reporter.
// {
// r := appconfigreporter.NewReporter(
// apiClient,
// gitClient,
// applicationLister,
// cfg,
// p.gracePeriod,
// input.Logger,
// )

// group.Go(func() error {
// return r.Run(ctx)
// })
// }
{
r := appconfigreporter.NewReporter(
apiClient,
gitClient,
applicationLister,
cfg,
p.gracePeriod,
input.Logger,
)

group.Go(func() error {
return r.Run(ctx)
})
}

// Wait until all piped components have finished.
// A terminating signal or a finish of any components
Expand Down

0 comments on commit 5aa9797

Please sign in to comment.