Skip to content

Commit

Permalink
Move domains field to managedCertificate block (#750)
Browse files Browse the repository at this point in the history
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

/cc @gkuga 
This PR was merged by Kapetanios.
  • Loading branch information
nghialv committed Sep 7, 2020
1 parent 370da34 commit 6fd1f6e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion manifests/pipecd/templates/managed-certificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
name: {{ include "pipecd.fullname" . }}
spec:
domains:
{{- range .Values.ingress.domains }}
{{- range .Values.managedCertificate.domains }}
- {{ . }}
{{- end }}
{{- end }}
4 changes: 1 addition & 3 deletions manifests/pipecd/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ backendConfig:

managedCertificate:
enabled: false
domains: []

ingress:
enabled: false
annotations: {}
# kubernetes.io/ingress.allow-http: "false"
# kubernetes.io/ingress.global-static-ip-name: pipecd
domains: []
# - api.pipecd.dev
# - dev.pipecd.dev

cors:
enabled: true
Expand Down

0 comments on commit 6fd1f6e

Please sign in to comment.