Skip to content

Commit

Permalink
Send error comment before plan preview exit (#4658)
Browse files Browse the repository at this point in the history
* Send error comment before plan preview exit

Signed-off-by: Takumaron <tennis.takumax@gmail.com>

* Apply review commnet

Signed-off-by: Takumaron <tennis.takumax@gmail.com>

---------

Signed-off-by: Takumaron <tennis.takumax@gmail.com>
  • Loading branch information
TakumaKurosawa committed Nov 9, 2023
1 parent 89fb203 commit 88d7fb6
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tool/actions-plan-preview/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,14 @@ func main() {
}

if event.PRClosed {
doComment(failureBadgeURL + "Unable to run plan-preview for a closed pull request.")
doComment(failureBadgeURL + "\nUnable to run plan-preview for a closed pull request.")
return
}

// TODO: When PR opened, `Mergeable` is nil for calculation.
// Here it is not considered for now, but needs to be handled.
if event.PRMergeable != nil && *event.PRMergeable == false {
doComment(failureBadgeURL + "Unable to run plan-preview for an un-mergeable pull request. Please resolve the conficts and try again.")
doComment(failureBadgeURL + "\nUnable to run plan-preview for an un-mergeable pull request. Please resolve the conficts and try again.")
return
}

Expand All @@ -123,6 +123,7 @@ func main() {
args.Timeout,
)
if err != nil {
doComment(failureBadgeURL + "\nUnable to run plan-preview. \ncause: " + err.Error())
log.Fatal(err)
}
log.Println("Successfully retrieved plan-preview result")
Expand All @@ -131,10 +132,11 @@ func main() {
if result.HasError() {
pr, err := getPullRequest(ctx, ghClient.PullRequests, event.Owner, event.Repo, event.PRNumber)
if err != nil {
doComment(failureBadgeURL + "\nUnable to run plan-preview. \ncause: " + err.Error())
log.Fatal(err)
}
if !pr.GetClosedAt().IsZero() {
doComment(failureBadgeURL + "Unable to run plan-preview for a closed pull request.")
doComment(failureBadgeURL + "\nUnable to run plan-preview for a closed pull request.")
return
}
}
Expand Down

0 comments on commit 88d7fb6

Please sign in to comment.