Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codegen base container image to use go v1.20.5 #4379

Closed
khanhtc1202 opened this issue Jun 8, 2023 · 5 comments
Closed

Upgrade codegen base container image to use go v1.20.5 #4379

khanhtc1202 opened this issue Jun 8, 2023 · 5 comments

Comments

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jun 8, 2023

Currently, the pipecd codegen workflow still uses the previous v0.37.x codegen container image, which is based on golang:v1.19.3-alpine3.15 container image.

@kentakozuka
Copy link
Member

gen workflow fails in generating mock because errors.Join was introduced in v0.44.2, which is only available for go1.20.

# github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
../pkg/app/piped/platformprovider/kubernetes/loader.go:99:16: undefined: errors.Join
note: module requires Go 1.20
# github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
../loader.go:99:16: undefined: errors.Join
note: module requires Go 1.20
go: finding module for package github.com/golang/mock/mockgen/model
go: finding module for package github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
go: downloading github.com/pipe-cd/pipecd v0.44.2
# github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
/go/pkg/mod/github.com/pipe-cd/pipecd@v0.44.2/pkg/app/piped/platformprovider/kubernetes/loader.go:99:16: undefined: errors.Join
note: module requires Go 1.20
2023/07/12 13:00:06 Loading input failed: exit status 2

@kentakozuka
Copy link
Member

was it proto related problem that we cannot use the latest image?

@khanhtc1202
Copy link
Member Author

well, the latest codegen image which based on go 1.20.5 can not generate proto as expected, that is why we still use the old one. Maybe the problem on proto tool chain 🤔

@kentakozuka
Copy link
Member

Let's find out the problem of this 👍 Otherwise, we cannot pass the CI workflow.

@khanhtc1202
Copy link
Member Author

Fixed by #4498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

2 participants