-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade codegen base container image to use go v1.20.5 #4379
Comments
gen workflow fails in generating mock because # github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
../pkg/app/piped/platformprovider/kubernetes/loader.go:99:16: undefined: errors.Join
note: module requires Go 1.20
# github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
../loader.go:99:16: undefined: errors.Join
note: module requires Go 1.20
go: finding module for package github.com/golang/mock/mockgen/model
go: finding module for package github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
go: downloading github.com/pipe-cd/pipecd v0.44.2
# github.com/pipe-cd/pipecd/pkg/app/piped/platformprovider/kubernetes
/go/pkg/mod/github.com/pipe-cd/pipecd@v0.44.2/pkg/app/piped/platformprovider/kubernetes/loader.go:99:16: undefined: errors.Join
note: module requires Go 1.20
2023/07/12 13:00:06 Loading input failed: exit status 2 |
was it proto related problem that we cannot use the latest image? |
well, the latest codegen image which based on go 1.20.5 can not generate proto as expected, that is why we still use the old one. Maybe the problem on proto tool chain 🤔 |
Let's find out the problem of this 👍 Otherwise, we cannot pass the CI workflow. |
Fixed by #4498 |
Currently, the pipecd codegen workflow still uses the previous v0.37.x codegen container image, which is based on
golang:v1.19.3-alpine3.15
container image.The text was updated successfully, but these errors were encountered: