Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged k8s.io/* packages #923

Closed
dulltz opened this issue Oct 6, 2020 · 1 comment · Fixed by #924
Closed

Use tagged k8s.io/* packages #923

dulltz opened this issue Oct 6, 2020 · 1 comment · Fixed by #924
Assignees
Labels
kind/enhancement New feature or request

Comments

@dulltz
Copy link

dulltz commented Oct 6, 2020

What would you like to be added:

Currently, this repository manages the k8s.io/* package with a commit hash specification,
but in this way, it's hard to tell which version of k8s.io package is used.

There is a straightforward way to manage k8s.io packages with tags.

like this:

--- a/go.mod
+++ b/go.mod
@@ -37,14 +37,8 @@ require (
        google.golang.org/grpc v1.31.1
        google.golang.org/protobuf v1.25.0
        istio.io/api v0.0.0-20200710191538-00b73d23c685
-       k8s.io/api v0.0.0-20200410021914-5778e4f3d00d
-       k8s.io/apimachinery v0.18.1
-       k8s.io/client-go v0.0.0-20200410022504-7b0589a2468d
+       k8s.io/api v0.18.2
+       k8s.io/apimachinery v0.18.2
+       k8s.io/client-go v0.18.2
        sigs.k8s.io/yaml v1.2.0
 )
-
-replace (
-       k8s.io/api => k8s.io/api v0.0.0-20200410021914-5778e4f3d00d
-       k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20200410021338-ff54c5b023af
-       k8s.io/client-go => k8s.io/client-go v0.0.0-20200410022504-7b0589a2468d
-)

Why is this needed:

To make it easier to know which version is used.

@nghialv
Copy link
Member

nghialv commented Oct 6, 2020

@dulltz Thank you for a nice suggestion. You're absolutely right.
The PR #924 will update them.

@nghialv nghialv self-assigned this Oct 6, 2020
pipecd-bot pushed a commit that referenced this issue Oct 6, 2020
**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #923

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants