Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the format and the way to generate piped key #121

Merged
merged 1 commit into from Jun 21, 2020
Merged

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Jun 21, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member Author

nghialv commented Jun 21, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 25.76%. This pull request increases coverage by 0.19%.

File Function Base Head Diff
pkg/model/piped.go generateRandomString -- 100.00% +100.00%

@pipecd-bot pipecd-bot merged commit 0a78e20 into master Jun 21, 2020
@pipecd-bot pipecd-bot deleted the piped-key branch June 21, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants