Restruct fake response of web api to fake api server #14
Conversation
| webservice.RegisterWebServiceServer(server, a) | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) AddEnvironment(ctx context.Context, req *webservice.AddEnvironmentRequest) (*webservice.AddEnvironmentResponse, error) { |
There was a problem hiding this comment.
ctx is unused in AddEnvironment
There was a problem hiding this comment.
A little tip to shut up the linters is to use _ like:
| func (a *FakeWebAPI) AddEnvironment(ctx context.Context, req *webservice.AddEnvironmentRequest) (*webservice.AddEnvironmentResponse, error) { | |
| func (a *FakeWebAPI) AddEnvironment(_ context.Context, _ *webservice.AddEnvironmentRequest) (*webservice.AddEnvironmentResponse, error) { |
However, this is a fake API which is rarely updated, so it's on you.
There was a problem hiding this comment.
Thank you. However, this will be implemented soon, so I keep it.
| webservice.RegisterWebServiceServer(server, a) | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) AddEnvironment(ctx context.Context, req *webservice.AddEnvironmentRequest) (*webservice.AddEnvironmentResponse, error) { |
There was a problem hiding this comment.
req is unused in AddEnvironment
| return nil, status.Error(codes.Unimplemented, "") | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) UpdateEnvironmentDesc(ctx context.Context, req *webservice.UpdateEnvironmentDescRequest) (*webservice.UpdateEnvironmentDescResponse, error) { |
There was a problem hiding this comment.
ctx is unused in UpdateEnvironmentDesc
| return nil, status.Error(codes.Unimplemented, "") | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) UpdateEnvironmentDesc(ctx context.Context, req *webservice.UpdateEnvironmentDescRequest) (*webservice.UpdateEnvironmentDescResponse, error) { |
There was a problem hiding this comment.
req is unused in UpdateEnvironmentDesc
| return nil, status.Error(codes.Unimplemented, "") | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) ListEnvironments(ctx context.Context, req *webservice.ListEnvironmentsRequest) (*webservice.ListEnvironmentsResponse, error) { |
There was a problem hiding this comment.
ctx is unused in ListEnvironments
| return nil, status.Error(codes.Unimplemented, "") | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetApplicationLiveState(ctx context.Context, req *webservice.GetApplicationLiveStateRequest) (*webservice.GetApplicationLiveStateResponse, error) { |
There was a problem hiding this comment.
ctx is unused in GetApplicationLiveState
| }, nil | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetProject(ctx context.Context, req *webservice.GetProjectRequest) (*webservice.GetProjectResponse, error) { |
There was a problem hiding this comment.
req is unused in GetProject
| }, nil | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetProject(ctx context.Context, req *webservice.GetProjectRequest) (*webservice.GetProjectResponse, error) { |
There was a problem hiding this comment.
ctx is unused in GetProject
| return nil, status.Error(codes.Unimplemented, "") | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetMe(ctx context.Context, req *webservice.GetMeRequest) (*webservice.GetMeResponse, error) { |
There was a problem hiding this comment.
ctx is unused in GetMe
| return nil, status.Error(codes.Unimplemented, "") | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetMe(ctx context.Context, req *webservice.GetMeRequest) (*webservice.GetMeResponse, error) { |
There was a problem hiding this comment.
req is unused in GetMe
|
Code coverage for golang is |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #13
Does this PR introduce a user-facing change?: