Update installation instruction for single machine #1921
Conversation
|
Code coverage for golang is |
| projectID: YOUR_PROJECT_ID | ||
| pipedID: YOUR_PIPED_ID | ||
| pipedKeyFile: PATH_TO_PIPED_KEY_FILE | ||
| projectID: {YOUR_PROJECT_ID} |
There was a problem hiding this comment.
to keep all config file syntax consistent, I think all values should be wrapped in { } or not at this time, so without { } is better to me. We can make it by another PR which change all other configuration files 👀
There was a problem hiding this comment.
I think all values should wrap in { } or not
I feel exactly the same way. But I'm guessing the ones enclosed with { } is better because there are a couple of fields to be all capitalized kind of like KUBERNETES, it can be confusing.
There was a problem hiding this comment.
Sure 👍 Then let's address it with another PR that refine all other configuration files 🙏
| ./piped piped \ | ||
| --config-file=PATH_TO_PIPED_CONFIG_FILE \ | ||
| --tools-dir=PATH_TO_TOOLS_DIR | ||
| ./piped piped --config-file=PATH_TO_PIPED_CONFIG_FILE |
|
🚀 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
It's because
--tools-dirandsshConfigFilePathwill be non-required from the next versionWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: