Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling web resources #1931

Merged
merged 1 commit into from Apr 27, 2021
Merged

Fix bundling web resources #1931

merged 1 commit into from Apr 27, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Apr 27, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

Fix some pages that were blank.

I think this bug has not appeared in the released version so no need to add this note 🤔

@nghialv
Copy link
Member

nghialv commented Apr 27, 2021

I think this bug has not appeared in the released version so no need to add this note 🤔

Agree.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.21%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.32%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

Thanks 🙏
/lgtm

@nghialv
Copy link
Member

nghialv commented Apr 27, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2c98b8b into master Apr 27, 2021
@pipecd-bot pipecd-bot deleted the fix-web-bundle branch April 27, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants