New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable piped authentication #21
Conversation
/cc @stormcat24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -39,7 +39,7 @@ type testPipedTokenVerifier struct { | |||
pipedKey string | |||
} | |||
|
|||
func (v testPipedTokenVerifier) Verify(projectID, pipedID, pipedKey string) error { | |||
func (v testPipedTokenVerifier) Verify(ctx context.Context, projectID, pipedID, pipedKey string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipedID
is unused in Verify
@@ -39,7 +39,7 @@ type testPipedTokenVerifier struct { | |||
pipedKey string | |||
} | |||
|
|||
func (v testPipedTokenVerifier) Verify(projectID, pipedID, pipedKey string) error { | |||
func (v testPipedTokenVerifier) Verify(ctx context.Context, projectID, pipedID, pipedKey string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctx
is unused in Verify
@@ -39,7 +39,7 @@ type testPipedTokenVerifier struct { | |||
pipedKey string | |||
} | |||
|
|||
func (v testPipedTokenVerifier) Verify(projectID, pipedID, pipedKey string) error { | |||
func (v testPipedTokenVerifier) Verify(ctx context.Context, projectID, pipedID, pipedKey string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectID
is unused in Verify
@@ -50,7 +50,7 @@ type testPipedTokenVerifier struct { | |||
pipedKey string | |||
} | |||
|
|||
func (v testPipedTokenVerifier) Verify(projectID, pipedID, pipedKey string) error { | |||
func (v testPipedTokenVerifier) Verify(ctx context.Context, projectID, pipedID, pipedKey string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctx
is unused in Verify
@@ -50,7 +50,7 @@ type testPipedTokenVerifier struct { | |||
pipedKey string | |||
} | |||
|
|||
func (v testPipedTokenVerifier) Verify(projectID, pipedID, pipedKey string) error { | |||
func (v testPipedTokenVerifier) Verify(ctx context.Context, projectID, pipedID, pipedKey string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
projectID
is unused in Verify
@@ -50,7 +50,7 @@ type testPipedTokenVerifier struct { | |||
pipedKey string | |||
} | |||
|
|||
func (v testPipedTokenVerifier) Verify(projectID, pipedID, pipedKey string) error { | |||
func (v testPipedTokenVerifier) Verify(ctx context.Context, projectID, pipedID, pipedKey string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipedID
is unused in Verify
Code coverage for golang is
|
/approve |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: